tweaks: reshuffle a condition, to avoid a repetition of code

master
Benno Schulenberg 2020-07-17 16:52:47 +02:00
parent 2623f39c7b
commit 8eddf7bc26
1 changed files with 4 additions and 9 deletions

View File

@ -1655,16 +1655,11 @@ bool make_backup_of(char *realname)
original = fopen(realname, "rb");
if (original == NULL) {
warn_and_briefly_pause(_("Cannot read original file"));
fclose(backup_file);
goto failure;
}
/* Copy the existing file to the backup. */
/* If opening succeeded, copy the existing file to the backup. */
if (original != NULL)
verdict = copy_file(original, backup_file, FALSE);
if (verdict < 0) {
if (original == NULL || verdict < 0) {
warn_and_briefly_pause(_("Cannot read original file"));
fclose(backup_file);
goto failure;