a850bb2513
moving: redraw not just the new current line but also the prior one
...
This fixes http://savannah.gnu.org/bugs/?51821 .
2017-08-22 19:21:47 +02:00
047cf9be9c
moving: improve retention of the target column somewhat
...
It's not yet good enough: when proper_x() pushes the index forward,
maybe it should also increase leftedge? Or go_forward_chunks()?
2017-08-22 16:11:20 +02:00
97896d30f1
moving: use the correct formula for pushing the index forward
...
This helps to fix https://savannah.gnu.org/bugs/?51787 .
Correction-by: David Lawrence Ramsey <pooka109@gmail.com>
2017-08-22 16:11:11 +02:00
fc367a32eb
moving: don't push x forward when backward movement lands on a split tab
...
This fixes https://savannah.gnu.org/bugs/?51809 .
2017-08-22 16:05:44 +02:00
5e10528759
display: revamp how screen updates are done in the movement code
...
When the screen is narrower than a tab is wide, the cursor does not need
to be on the first/last line of the window before an <Up>/<Down> could
need to scroll the screen.
This fixes http://savannah.gnu.org/bugs/?51776 .
Reported-by: David Lawrence Ramsey <pooka109@gmail.com>
2017-08-21 21:25:55 +02:00
243380c4a2
mouse: one click of the wheel should move three lines, not three pages
...
This fixes https://savannah.gnu.org/bugs/?51802 .
2017-08-20 20:45:56 +02:00
49fb755cfc
moving: get <Up> unstuck when trying to pass over a sprawling tab
...
This is a temporary fix. The resultant movement is erratic and
not what is desired (which is: to stay in the same screen column
as much as possible).
2017-08-20 20:26:05 +02:00
24a64d37dd
softwrap: properly move up and down over tabs that are split over rows
...
Also, move home to the first character after the tab if the current
chunk starts with a partial tab.
This fixes https://savannah.gnu.org/bugs/?51800 .
Original-idea-by: David Lawrence Ramsey <pooka109@gmail.com>
2017-08-20 20:24:58 +02:00
a56a881c4b
browser: correct the inverted search behavior for Alt+Up/Alt+Down
...
This should have been added and amended in the previous commit --
my mistake.
2017-08-20 09:22:19 +02:00
633343de24
browser: allow backward/forward re-searches with Alt+Up/Alt+Down
...
Also bind 'N' to a backward re-search, while retaining 'n' for a
forward one, This matches the functionality in the help viewer.
2017-08-19 21:49:32 +02:00
5fcda555ea
display: constrain line numbers on softwrapped lines with sprawling tabs
...
Check the column number, not the character index, when suppressing the
line number on chunks other than the first, since the index can be zero
when in fact we're on a later chunk.
This fixes https://savannah.gnu.org/bugs/index.php?51790 .
2017-08-19 20:50:01 +02:00
873f99d96a
tweaks: show "where is next" in the help lines of the file browser
2017-08-19 18:11:59 +02:00
b38b020d18
tweaks: fix compilation with --enable-{tiny,help,multibuffer}
...
This fixes https://savannah.gnu.org/bugs/?51777 .
Reported-by: David Lawrence Ramsey <pooka109@gmail.com>
2017-08-19 17:35:58 +02:00
54a92614b2
tweaks: group all movement routines in corresponding pairs
2017-08-18 22:20:32 +02:00
86e71fa09d
tweaks: specify more directly in what manner to move the viewport
2017-08-18 21:46:55 +02:00
5237a42d65
weeding: remove the unused be_clever parameter from do_home()/do_end()
2017-08-18 20:44:46 +02:00
46ccc9ba6a
softwrap: improve left/right navigation across line boundaries
...
Using do_up() and do_end() when the user types <Left> at the start of
a line, and do_down() and do_home() when typing <Right> at line's end
can be problematic when tabs are wider than the screen, because those
functions convert indexes to columns and back again twice, thus causing
inaccuracies. Therefore, simply adjust current and current_x directly,
and then redraw the screen.
This fixes https://savannah.gnu.org/bugs/index.php?51778 .
2017-08-18 20:04:23 +02:00
e09dbf18b1
display: do show the visible character for a tab when it starts a row
...
Regardless of whether the row start is at a multiple of the tab size.
This completes the fix for https://savannah.gnu.org/bugs/?51669 .
2017-08-17 20:09:50 +02:00
f08d169aa1
softwrap: make sure char_len is set when a tab is wider than a chunk
...
This fixes https://savannah.gnu.org/bugs/?51770 ,
and fixes https://savannah.gnu.org/bugs/?51768 .
Reported-by: David Lawrence Ramsey <pooka109@gmail.com>
2017-08-17 19:39:51 +02:00
cf14ee2ef3
moving: the current chunk is always 0 when not in softwrap mode
...
This is a partial fix for https://savannah.gnu.org/bugs/?51770 .
Analysis-by: David Lawrence Ramsey <pooka109@gmail.com>
2017-08-17 19:33:43 +02:00
8555820afc
tweaks: rename a label, to better match its task
2017-08-16 22:00:10 +02:00
e7bdfebdf4
rcfile: don't leak a shortcut when something goes wrong [coverity scan]
2017-08-16 21:56:56 +02:00
4bbbb1859b
tweaks: adjust the indentation after the previous change
...
Also rename a variable, to match the saving routine.
2017-08-16 21:46:39 +02:00
6645351bfc
tweaks: avoid trying to stat a file that might be NULL [coverity scan]
2017-08-16 21:39:41 +02:00
a5981ab043
tweaks: don't close a descriptor when its stream has already been closed
2017-08-16 20:31:38 +02:00
807f5c2e69
tweaks: do not leak the indentation when all lines are empty
2017-08-16 17:16:18 +02:00
1b2a091de9
tweaks: condense or improve some comments
...
Also reshuffle an initialization and drop two useless asserts.
2017-08-16 17:10:40 +02:00
bd770ea2e7
text: properly unindent lines that consist of only whitespace
...
The preceding 'for' loop has already established that all the lines are
either unindentable or composed of only blanks. So if now a line cannot
be unindented, it means it is fully blank, so it can be simply skipped.
This fixes https://savannah.gnu.org/bugs/?51760 .
Reported-by: David Lawrence Ramsey <pooka109@gmail.com>
2017-08-16 16:42:44 +02:00
c3de3ece32
gnulib: update to its current upstream state
2017-08-15 22:00:14 +02:00
8b86af3fef
tweaks: adjust the indentation after the previous change
2017-08-15 19:13:22 +02:00
21a5978027
tweaks: reshuffle some code to harmonize two related functions
2017-08-15 18:05:06 +02:00
b4fd08fa5e
tweaks: keep the const qualifier of the syntax name [coverity scan]
...
Also, reduce the scope of the 'line' variable.
2017-08-15 17:20:07 +02:00
252dc138a2
tweaks: reshuffle some declarations and trim a few comments
2017-08-15 14:15:23 +02:00
de57d8b722
files: don't try to open a negative file descriptor [coverity scan]
2017-08-15 13:48:25 +02:00
dbbe267d71
files: don't close a file descriptor when opening failed [coverity scan]
...
Also, don't depend on statting the relative path, because if that would
fail, we would try to open a NULL pointer.
2017-08-15 13:06:31 +02:00
eed0090e32
tweaks: close a file also in the error path [coverity scan]
2017-08-15 12:24:18 +02:00
52e2e52db3
tweaks: allow enough space for the Y/N/A characters [coverity scan]
2017-08-15 12:04:52 +02:00
3f0e42c13b
syntax: c: give labels some color too
2017-08-15 11:00:31 +02:00
d8e5799e84
tweaks: adjust the indentation after the previous change
...
Also, trim or improve some comments.
2017-08-15 10:38:58 +02:00
0f4716e168
text: make unindenting remove from the beginning of the line
...
Also, only unindent when all selected lines can be unindented,
which means that the relative indentation will be preserved.
For this purpose, it ignores empty lines and lines consisting
of only whitespace.
When unindenting is not possible, a message is shown.
This fixes https://savannah.gnu.org/bugs/?47684 .
2017-08-15 10:38:58 +02:00
749b1b3d79
text: make indenting add to the beginning of the line
...
Instead of inserting the extra whitespace after the current indentation
of a line, add it to the start of the line. This causes a fixed amount
of visual whitespace to be added regardless of whether --tabstospaces
is used or not.
This fixes http://savannah.gnu.org/bugs/?51438 ,
and its ancestor https://savannah.gnu.org/bugs/?51408 .
2017-08-15 10:38:58 +02:00
566a2daf12
tweaks: remove unneeded parentheses and blank line and braces
2017-08-14 21:46:25 +02:00
9f6c3a6269
display: don't doubly show tabs that cross a chunk boundary
...
This fixes https://savannah.gnu.org/bugs/?51669 .
Reported-by: David Lawrence Ramsey <pooka109@gmail.com>
2017-08-14 21:31:55 +02:00
6273768797
tweaks: renumber the special key codes, to be in sequence and grouped
2017-08-14 10:42:09 +02:00
4562401505
bindings: hard-bind Alt+Up and Alt+Down to findprevious and findnext
...
So that these functions have bindings by default, and easy bindings.
Add them to the help viewer too, so that searching backward becomes
possible there.
2017-08-14 10:34:15 +02:00
1cc030f7c1
bindings: hard-bind Alt+Left and Alt+Right to buffer switching
...
This also fixes https://savannah.gnu.org/bugs/?51735 .
Reported-by: Urja Rannikko <urjaman@gmail.com>
Signed-off-by: Urja Rannikko <urjaman@gmail.com>
Signed-off-by: Benno Schulenberg <bensberg@telfort.nl>
2017-08-14 10:06:29 +02:00
65d1655134
softwrap: don't push a straddling tab to the next chunk
...
Tabs are of variable length depending on position, so allow them
to be displayed partially on one chunk and partially on another.
This fixes http://savannah.gnu.org/bugs/?51621 .
2017-08-13 21:06:23 +02:00
8e779b6e85
softwrap: properly update the viewport when adding text at firstcolumn
...
Adding text plus whitespace while the cursor is at or near the topleft
corner of the edit window can cause a change in the preceding chunk,
throwing firstcolumn out of alignment. Catch this special case.
This fixes http://savannah.gnu.org/bugs/?51743 .
2017-08-13 13:46:49 +02:00
3ab943c49a
tweaks: condense some logic, to elide a variable and a comment
2017-08-13 10:09:02 +02:00
ec20e3a7a8
tweaks: rename a function, to let it make more sense
...
Further, slightly reword an error message so it is appropriate also
when an out-of-bounds file is specified on the command line.
2017-08-13 10:08:50 +02:00
David Lawrence Ramsey