canoeboot
/
cbmk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

roms: build coreboot early to avoid duplicate work 

we're building it per coreboot configuration file, rather
than per-target; the latter is more appropriate, and saves
on compilation time.

do it per-target.cfg, not per coreboot configuration.

this works because the trees script compiles all images
per target, for each given coreboot configuration within
that target, e.g. libgfxinit _corebootfb and _txtmode.

Signed-off-by: Leah Rowe <leah@libreboot.org>
audit2
Leah Rowe 2024-06-24 17:28:25 +01:00 committed by Leah Rowe
parent df66dbd72d
commit d0a949d00b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
script/roms
View File

@ -91,6 +91,7 @@ configure_target()
# Override the above defaults using target.cfg # Override the above defaults using target.cfg
eval `setcfg "$targetdir/target.cfg"` eval `setcfg "$targetdir/target.cfg"`
x_ ./update trees -b coreboot $board
[ -z "$tree" ] && $err "$board: tree not defined" [ -z "$tree" ] && $err "$board: tree not defined"
[ "$xbmk_release" = "y" ] && [ "$release" = "n" ] && return 1 [ "$xbmk_release" = "y" ] && [ "$release" = "n" ] && return 1
@ -135,8 +136,6 @@ build_board()
build_roms() build_roms()
{ {
x_ ./update trees -b coreboot $board
cbuild="$cbelfdir/$board/${initmode}_$displaymode" cbuild="$cbelfdir/$board/${initmode}_$displaymode"
[ "$initmode" = "normal" ] && cbuild="${cbuild%"_$displaymode"}" [ "$initmode" = "normal" ] && cbuild="${cbuild%"_$displaymode"}"
x_ cp "$cbuild/coreboot.rom" "$tmprom" x_ cp "$cbuild/coreboot.rom" "$tmprom"