fortressia
/
echidna
1
1
Fork 0
Code Issues 15 Pull Requests 2 Projects Releases Wiki Activity

feat: make tabs closeable #9

Merged
fortressia merged 1 commits from feat/closable-tabs into main 2021-11-07 12:26:37 +00:00
Conversation 18 Commits 1 Files Changed 1
fortressia commented 2021-11-03 10:12:27 +00:00 (Migrated from gitlab.com)

Closes #17.

  • Implement ClosableTabsImplementedNotebook::prepend_closable_tab().
  • Implement ClosableTabsImplementedNotebook::append_closable_tab().
  • Implement this for the placeholder Getting Started page. The placeholder Getting Started page has been removed by d54f470a.
Closes #17. - [x] Implement `ClosableTabsImplementedNotebook::prepend_closable_tab()`. - [x] Implement `ClosableTabsImplementedNotebook::append_closable_tab()`. - [x] ~~Implement this for the placeholder Getting Started page.~~ The placeholder Getting Started page has been removed by d54f470a.
fortressia commented 2021-11-03 10:12:28 +00:00 (Migrated from gitlab.com)

assigned to @FortressNordlys

assigned to @FortressNordlys
fortressia commented 2021-11-03 10:12:49 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
fortressia commented 2021-11-03 11:55:04 +00:00 (Migrated from gitlab.com)

added 1 commit

  • 8eb2e9c6 - refactor: move back workspace.rs to src/components/window

Compare with previous version

added 1 commit <ul><li>8eb2e9c6 - refactor: move back workspace.rs to src/components/window</li></ul> [Compare with previous version](/EchidnaHQ/Echidna/-/merge_requests/9/diffs?diff_id=272199258&start_sha=af347c89621e6dc01ce316478ad2e1d804bcd80a)
fortressia commented 2021-11-04 10:06:50 +00:00 (Migrated from gitlab.com)

added 1 commit

  • d54f470a - refactor: remove placeholder Getting Started page

Compare with previous version

added 1 commit <ul><li>d54f470a - refactor: remove placeholder Getting Started page</li></ul> [Compare with previous version](/EchidnaHQ/Echidna/-/merge_requests/9/diffs?diff_id=272868785&start_sha=8eb2e9c66a5b0bb575eaf4192993d3f1af9d172d)
fortressia commented 2021-11-04 11:54:48 +00:00 (Migrated from gitlab.com)

marked the task Implement this for the placeholder Getting Started page. as completed

marked the task **Implement this for the placeholder Getting Started page.** as completed
fortressia commented 2021-11-04 11:54:49 +00:00 (Migrated from gitlab.com)

marked the task Implement this for the placeholder Getting Started page. as incomplete

marked the task **Implement this for the placeholder Getting Started page.** as incomplete
fortressia commented 2021-11-04 11:57:24 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
fortressia commented 2021-11-04 11:57:51 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
fortressia commented 2021-11-04 11:58:05 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
fortressia commented 2021-11-06 09:57:16 +00:00 (Migrated from gitlab.com)

marked the task Implement ClosableTabsImplementedNotebook::prepend_closable_tab(). as completed

marked the task **Implement `ClosableTabsImplementedNotebook::prepend_closable_tab()`.** as completed
fortressia commented 2021-11-06 10:02:57 +00:00 (Migrated from gitlab.com)

added 2 commits

  • 2ec23a35 - fix: prepend_closable_tab appending tabs
  • 2b2e63d8 - feat: ClosableTabImplNotebook::append_closable_tab()

Compare with previous version

added 2 commits <ul><li>2ec23a35 - fix: prepend_closable_tab appending tabs</li><li>2b2e63d8 - feat: ClosableTabImplNotebook::append_closable_tab()</li></ul> [Compare with previous version](/EchidnaHQ/Echidna/-/merge_requests/9/diffs?diff_id=274145560&start_sha=d54f470a76727584660ae0c79d48a2ef4570f7da)
fortressia commented 2021-11-06 10:04:17 +00:00 (Migrated from gitlab.com)

marked the task Implement ClosableTabsImplementedNotebook::append_closable_tab(). as completed

marked the task **Implement `ClosableTabsImplementedNotebook::append_closable_tab()`.** as completed
fortressia commented 2021-11-06 10:04:51 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
fortressia commented 2021-11-06 10:05:59 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
fortressia commented 2021-11-06 10:06:15 +00:00 (Migrated from gitlab.com)

requested review from @VoltrexMaster

requested review from @VoltrexMaster
fortressia commented 2021-11-06 10:06:21 +00:00 (Migrated from gitlab.com)

marked this merge request as ready

marked this merge request as **ready**
VoltrexMaster commented 2021-11-07 12:07:43 +00:00 (Migrated from gitlab.com)

approved this merge request

approved this merge request
fortressia commented 2021-11-07 12:26:37 +00:00 (Migrated from gitlab.com)

mentioned in commit 9569348767

mentioned in commit 9569348767b87a19b1b442dea597371682474f25
VoltrexMaster (Migrated from gitlab.com) approved these changes 2021-12-27 13:18:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
VoltrexMaster
Labels
Clear labels   
bug
   
documentation
   
duplicate
   
feat

Stands for 'feature', this label for new features.   
good first issue
   
help wanted
   
in-progress
   
invalid
   
question
   
refactor

This label for issues and MRs that rewrites code.   
wontfix
No Label
bug
documentation
duplicate
feat
good first issue
help wanted
in-progress
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fortressia/echidna#9
There is no content yet.
Delete Branch "feat/closable-tabs"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?