refactor: make tab label their own widget #15
No reviewers
Labels
No Label
bug
documentation
duplicate
feat
good first issue
help wanted
in-progress
invalid
question
refactor
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: fortressia/echidna#15
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "refactor/closable-tabs"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Description
This helps with downcasting which greatly helps with type safety.
Closes
N/A
Implementation Insight
I created a custom widget called TabLabel, which is just a simple Box subclass with access to the close button, the constructor optionally takes a tab_label parameter, which should be a widget that will be prepended to the front.
TO-DOs
N/A
requested review from @VoltrexMaster
assigned to @fortressia
mentioned in commit
c1193df8a2