refactor: make tab label their own widget #15

Merged
fortressia merged 1 commits from refactor/closable-tabs into main 2021-12-17 02:29:51 +00:00
fortressia commented 2021-11-15 00:18:45 +00:00 (Migrated from gitlab.com)

Description

This helps with downcasting which greatly helps with type safety.

Closes

N/A

Implementation Insight

I created a custom widget called TabLabel, which is just a simple Box subclass with access to the close button, the constructor optionally takes a tab_label parameter, which should be a widget that will be prepended to the front.

TO-DOs

N/A

# Description This helps with downcasting which greatly helps with type safety. # Closes N/A # Implementation Insight I created a custom widget called TabLabel, which is just a simple Box subclass with access to the close button, the constructor optionally takes a tab_label parameter, which should be a widget that will be prepended to the front. # TO-DOs N/A
fortressia commented 2021-11-15 00:18:45 +00:00 (Migrated from gitlab.com)

requested review from @VoltrexMaster

requested review from @VoltrexMaster
fortressia commented 2021-11-15 00:18:46 +00:00 (Migrated from gitlab.com)

assigned to @fortressia

assigned to @fortressia
fortressia commented 2021-12-17 02:29:51 +00:00 (Migrated from gitlab.com)

mentioned in commit c1193df8a2

mentioned in commit c1193df8a2298c7e01d8062842b0ffe991041cfe
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fortressia/echidna#15
There is no content yet.