libreboot
/
lbmk
1
0
Fork 0
Code Packages Projects Releases Activity

roms: simplified ubootelf check 

we check it twice, which we don't need to do.

we only need to check it once!

Signed-off-by: Leah Rowe <leah@libreboot.org>
audit6-merge1
Leah Rowe 2024-06-15 23:58:27 +01:00
parent a9166898d2
commit 0dfe3aed91
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
script/roms
View File

@ -20,8 +20,8 @@ stm32src="src/stm32-vserprog"
# target.cfg files have to specifically enable [a] payload(s) # target.cfg files have to specifically enable [a] payload(s)
pv="payload_uboot payload_grub_withseabios payload_seabios payload_memtest t" pv="payload_uboot payload_grub_withseabios payload_seabios payload_memtest t"
pv="$pv payload_seabios_withgrub payload_seabios_grubonly payload_grub mt86bin" pv="$pv payload_seabios_withgrub payload_seabios_grubonly payload_grub mt86bin"
v="romdir cbrom initmode displaymode cbcfg targetdir tree release" v="romdir cbrom initmode displaymode cbcfg targetdir tree release ubootelf"
v="$v grub_timeout ubdir board grub_scan_disk uboot_config grubtree grubelf" v="$v grub_timeout board grub_scan_disk uboot_config grubtree grubelf"
eval "$(setvars "n" $pv)" eval "$(setvars "n" $pv)"
eval "$(setvars "" $v boards targets serprog_boards_dir)" eval "$(setvars "" $v boards targets serprog_boards_dir)"
@ -170,9 +170,8 @@ build_uboot_payload()
{ {
x_ ./update trees -b u-boot $board x_ ./update trees -b u-boot $board
ubdir="elf/u-boot/$board/$uboot_config" ubdir="elf/u-boot/$board/$uboot_config"
ubootelf="$ubdir/u-boot.elf" ubootelf="$ubdir/u-boot.elf" && [ ! -f "$ubootelf" ] && \
[ ! -f "$ubootelf" ] && [ -f "$ubdir/u-boot" ] && \ ubootelf="$ubdir/u-boot"
ubootelf="$ubdir/u-boot"
[ -f "$ubootelf" ] || $err "$board: Can't find u-boot"; return 0 [ -f "$ubootelf" ] || $err "$board: Can't find u-boot"; return 0
} }
@ -318,15 +317,10 @@ mkUbootRom() {
_cbrom="$1" _cbrom="$1"
_uboot_cbfs_path="$2" _uboot_cbfs_path="$2"
_ubdir="elf/u-boot/$board/$uboot_config"
_ubootelf="$_ubdir/u-boot.elf"
[ -f "$_ubootelf" ] || _ubootelf="$_ubdir/u-boot"
[ -f "$_ubootelf" ] || $err "mkUbootRom: $board: cant find u-boot"
tmprom="$(mktemp -t coreboot_rom.XXXXXXXXXX)" tmprom="$(mktemp -t coreboot_rom.XXXXXXXXXX)"
x_ cp "$_cbrom" "$tmprom" x_ cp "$_cbrom" "$tmprom"
cbfs "$tmprom" "$_ubootelf" "$_uboot_cbfs_path" cbfs "$tmprom" "$ubootelf" "$_uboot_cbfs_path"
printf "%s\n" "$tmprom" printf "%s\n" "$tmprom"
} }