libreboot
/
lbmk
1
0
Fork 0
Code Packages Projects Releases Activity

include/blobutil: properly set global variables 

I was setting certain global variables inside for loops,
but some sh implementations won't like this.

Instead, don't run eval inside the for loops. Set a string
for eval inside the for loops, then execute eval outside of
the loops. This should work on every shell.

Signed-off-by: Leah Rowe <leah@libreboot.org>
btrfsvols
Leah Rowe 2023-09-28 02:28:51 +01:00
parent e9e1a3b4ae
commit 178b888aa0
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
include/blobutil.sh
View File

@ -9,16 +9,17 @@ _b=""
blobdir="blobs"
appdir="${blobdir}/app"
for x in EC_url EC_url_bkup EC_hash DL_hash DL_url DL_url_bkup dl_path \
setvars="EC_url=\"\""
for x in EC_url_bkup EC_hash DL_hash DL_url DL_url_bkup dl_path \
E6400_VGA_DL_hash E6400_VGA_DL_url E6400_VGA_DL_url_bkup E6400_VGA_offset \
E6400_VGA_romname SCH5545EC_DL_url SCH5545EC_DL_url_bkup \
SCH5545EC_DL_hash; do
eval "${x}=\"\""
setvars="${setvars}; ${x}=\"\""
done
for x in sname archive _filetype rom board modifygbe new_mac release \
releasearchive vendor_rom; do
eval "${x}=\"\""
setvars="${setvars}; ${x}=\"\""
done
cbdir="coreboot/default"
@ -43,5 +44,7 @@ for x in _me_destination _gbe_destination _ifd_destination \
CONFIG_VGA_BIOS_FILE CONFIG_VGA_BIOS_ID CONFIG_GBE_BIN_PATH \
CONFIG_INCLUDE_SMSC_SCH5545_EC_FW CONFIG_SMSC_SCH5545_EC_FW_FILE \
CONFIG_IFD_BIN_PATH; do
eval "${x}=\"\""
setvars="${setvars}; ${x}=\"\""
done
eval "${setvars}"