libreboot
/
lbmk
1
0
Fork 0
Code Packages Projects Releases Activity

util/nvmutil: fix possible regression 

i went too hard on the sloc reductions

a check inside a for loop could cause
incomplete reading of gbe images

revert that
fsdg20230625
Leah Rowe 2023-04-07 02:08:06 +01:00
parent 01e2ed3034
commit 34eeca1f03
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/nvmutil/nvmutil.c
View File

@ -164,7 +164,9 @@ readGbeFile(int *fd, const char *path, int flags, size_t nr)
else if (errno == ENOTDIR)
errno = 0;
for (int p = 0; (p < 2) && (!skipread[p]); p++) {
for (int p = 0; p < 2; p++) {
if (skipread[p])
continue;
if (pread((*fd), (uint8_t *) gbe[p], nr, p << 12) == -1)
err(errno, "%s", path);
if (big_endian)