libreboot
/
lbmk
1
0
Fork 0
Code Packages Projects Releases Activity

build/boot/roms: check all targets before building 

If one of them doesn't exist, error out.

Previously, a build would start but then it would
error out later on. This implements the mentality:

fail early, fail hard

Signed-off-by: Leah Rowe <leah@libreboot.org>
btrfsvols
Leah Rowe 2023-09-30 13:21:15 +01:00
parent 6125d3418f
commit 4afa0aaa3c
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
script/build/boot/roms
View File

@ -57,15 +57,23 @@ handle_targets()
[ "${first}" != "all" ] || boards="$(listitems config/coreboot)" || \ [ "${first}" != "all" ] || boards="$(listitems config/coreboot)" || \
err "handle_targets: Cannot get list of boards" err "handle_targets: Cannot get list of boards"
check_targets
for board in ${boards}; do for board in ${boards}; do
[ -d "config/coreboot/${board}/" ] || \
err "handle_targets: target not defined: ${board}"
./build boot roms_helper ${board}${opts} || \ ./build boot roms_helper ${board}${opts} || \
err "handle_targets ${board}${opts}: build error" err "handle_targets ${board}${opts}: build error"
[ -d "bin/${board}" ] && targets="${board} ${targets}" [ -d "bin/${board}" ] && targets="${board} ${targets}"
done done
} }
check_targets()
{
for board in ${boards}; do
[ -d "config/coreboot/${board}/" ] || \
err "check_targets: target not defined: ${board}"
done
}
confirm_targets() confirm_targets()
{ {
[ -z "${targets}" ] && err "No ROM images were compiled." [ -z "${targets}" ] && err "No ROM images were compiled."