libreboot
/
lbmk
1
0
Fork 0
Code Packages Projects Releases Activity

util/nvmutil: fix faulty zeroes-mac-address check 

it was resetting the total for each nibble. absolute
epic fail on my part.

fixed now.
fsdg20230625
Leah Rowe 2023-04-05 21:53:12 +01:00
parent 0c79a9a82e
commit b0fa54ac41
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/nvmutil/nvmutil.c
View File

@ -205,7 +205,7 @@ parseMacAddress(const char *strMac, uint16_t *mac)
int i, nib, byte;
uint8_t val8;
uint16_t val16;
uint64_t total;
uint64_t total = 0;
if (strnlen(strMac, 20) != 17)
return -1;
@ -215,7 +215,7 @@ parseMacAddress(const char *strMac, uint16_t *mac)
if (strMac[i + 2] != ':')
return -1;
byte = i / 3;
for (total = 0, nib = 0; nib < 2; nib++, total += val8) {
for (nib = 0; nib < 2; nib++, total += val8) {
if ((val8 = hextonum(strMac[i + nib])) > 15)
return -1;
if ((byte == 0) && (nib == 1))