06a92f61a8
build/clean/ich9utils: don't use subshell
...
this also fixes error handling
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 21:38:54 +01:00
43e2dfe2bf
build/u-boot: top-down, split-function code style
...
main() on top
top-down order of logic
logic split into separate functions
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 21:33:37 +01:00
a8f0721a6f
build/payload/u-boot: 79 chars or less per line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:48:19 +01:00
89ac1ea5a9
build/payload/u-boot: fix wrong attributions
...
only alper and ferass have ownership of this file,
but ferass only submitted to it in 2022, not 2021
fix this
i've removed myself from the file, for now
i never touched this file before, so it's
not right that my name be here
put alper's name at the top, because alper
was the person who created this file first
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:32:40 +01:00
c973b95909
build/payload/grub: rename functions for clarity
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:16:10 +01:00
51e0e40123
build/payload/grub: remove unnecessary check
...
sed does the same job as cp, in this situation
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:08:40 +01:00
8e206be7c8
build/payload/grub: split logic into functions
...
main() on top
top-down logic
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:07:22 +01:00
db7e81612a
build/payload/grub: 79 chars or less per line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:55:40 +01:00
92bd18c45a
build/release/roms: minor cleanup
...
split actual purging of blobs to a function
rename functions for clarity
2023-05-20 19:45:08 +01:00
ec3d1006b3
build/release/roms: handle argument properly
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:40:31 +01:00
e0b9766087
build/release/roms: remove superfluous comments
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:36:51 +01:00
681538a20c
build/release/roms: handle errors inside subshell
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:35:36 +01:00
a9bd54423c
build/release/roms: split logic into functions
...
main() on top
top-down logic
79 chars or less, per line
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:33:29 +01:00
2983309006
build/release/roms: use tabs for indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:15:50 +01:00
fff5fa53ff
build/release/src: 79 chars or less per code line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:03:04 +01:00
1cdf1c7cf0
build/release/src: handle errors in subshells
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:59:59 +01:00
16f878e882
build/release/src: split logic into functions
...
main() on top
top-down logic
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:52:33 +01:00
4e2ee58ac5
build/ich9utils: simplify, fix error handling
...
errors weren't being handled inside a subshell
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:32:52 +01:00
93ec91e862
build/memtest86plus: use tabs for indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:28:58 +01:00
4b80f250fb
build/clean/crossgcc: better code style
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:28:17 +01:00
187d5fa418
build/descriptors: simplify and fix error handling
...
main() on top
some parts of the script weren't erroring properly
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:26:09 +01:00
a05be16998
build/grub: fix inconsistent indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:13:44 +01:00
02919c47ce
build/grub: implement error handling
...
it uses a subshell, so errors weren't observed
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:10:41 +01:00
5bab3bbc33
build/grub: introduce main(), split it up
...
easier to read
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:06:15 +01:00
277e1df0af
build/cbutils: remove unnecessary directory check
...
it will already fail if the coreboot download did.
if the coreboot download succeeds, the directory exists.
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:01:02 +01:00
ed9eb4624c
build/cbutils: rename function for clarity
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:00:31 +01:00
b12dced470
build/cbutil: avoid frivilous use of subshells
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 17:57:15 +01:00
355a45b435
build/cbutils: top-down coding style, main on top
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 17:53:03 +01:00
9f58d4e481
build/cbutils: 79 chars or less per line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 16:13:02 +01:00
691f266441
build/cbutils: use tabs for indendation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 16:12:25 +01:00
1388cccbc7
build/seabios: cleaner coding style
...
top-down logic, main() on top
moved some hardcoded strings to variables
2023-05-14 21:33:19 +01:00
ddad8f00c6
build/seabios: simplify. stricter error handling
2023-05-14 21:22:06 +01:00
d90dfb0a08
build/dependencies/*: RFC 2646 compliance
2023-05-14 10:33:35 +01:00
c8dfc3ccaa
build/build/roms: simplify mkCoreboot() arguments
2023-05-13 03:06:55 +01:00
d8a8a1c622
build/boot/roms: don't use subshells frivilously
...
use make -BC instead of cd
2023-05-13 02:52:42 +01:00
834be77c1d
build/boot/roms: remove errant debug line
...
i added this in the last revision
it was put there to debug something that
i fixed before pushing
2023-05-13 02:36:09 +01:00
39c143989c
build/boot/roms: simplify build_rom_images()
2023-05-13 02:32:44 +01:00
65dfdd56da
build/boot/roms: use fast dd command for ich9m ifd
...
bs 12k and count 1, rather than bs 1 and count 12k
2023-05-13 01:38:59 +01:00
6a4ce66f6e
build/boot/roms: don't run ich9gen twice
2023-05-13 01:34:29 +01:00
1e9ed989d3
build/boot/roms: simplify moverom()
2023-05-13 01:27:00 +01:00
5811e53e82
build/boot/roms: remove unused legacy code
...
this cuttype is no longer used
lbmk creates truncated me setups now, on ifd platforms
2023-05-13 01:07:53 +01:00
3bd82b7679
build/boot/roms: reduced code indentation
2023-05-13 00:13:54 +01:00
9eee0fb483
build/boot/roms: split main() to topdown functions
...
the logic can now more or less be read chronologically
2023-05-12 23:09:39 +01:00
bceb5f2eb4
build/roms_helper: move logic into main()
...
logic will be split from main into smaller
functions, in follow-up commits
2023-05-12 16:55:45 +01:00
6290f999e2
build/boot/roms_helper: further cleanup
...
consolidated some for loops
removed errant code
2023-05-10 20:23:18 +01:00
722c844ea7
build/boot/roms: top-down function order
2023-05-10 05:39:11 +01:00
5f44556f47
build/roms: general code style cleanup
2023-05-10 05:09:10 +01:00
d521fca7ef
build/roms: fix faulty keymap list expansion
2023-05-10 04:40:48 +01:00
67a607b88c
build/boot/roms*: RFC 2646 compliance
...
No more than 80 characters per line.
2023-05-10 02:48:34 +01:00
3f1ee01507
seabios: do normal config, disable oprom in vgarom
...
previously, "normal" initmode relied on the vgarom-based
seabios config, which enables option roms, but then lbmk
would insert pci-optionrom-exec 0 for vgarom, and 2 for normal
in libreboot, coreboot roms with "vgarom" in the filename do
pci option rom execution from coreboot, and "normal" roms
do execution from seabios(where seabios is the only payload
provided on normal setups)
this is because payloads like grub can also be used, on vgarom
setups, where coreboot must handle oprom execution
2023-05-09 20:40:12 +01:00
Leah Rowe