06a92f61a8
build/clean/ich9utils: don't use subshell
...
this also fixes error handling
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 21:38:54 +01:00
43e2dfe2bf
build/u-boot: top-down, split-function code style
...
main() on top
top-down order of logic
logic split into separate functions
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 21:33:37 +01:00
a8f0721a6f
build/payload/u-boot: 79 chars or less per line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:48:19 +01:00
89ac1ea5a9
build/payload/u-boot: fix wrong attributions
...
only alper and ferass have ownership of this file,
but ferass only submitted to it in 2022, not 2021
fix this
i've removed myself from the file, for now
i never touched this file before, so it's
not right that my name be here
put alper's name at the top, because alper
was the person who created this file first
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:32:40 +01:00
c973b95909
build/payload/grub: rename functions for clarity
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:16:10 +01:00
51e0e40123
build/payload/grub: remove unnecessary check
...
sed does the same job as cp, in this situation
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:08:40 +01:00
8e206be7c8
build/payload/grub: split logic into functions
...
main() on top
top-down logic
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 20:07:22 +01:00
db7e81612a
build/payload/grub: 79 chars or less per line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:55:40 +01:00
92bd18c45a
build/release/roms: minor cleanup
...
split actual purging of blobs to a function
rename functions for clarity
2023-05-20 19:45:08 +01:00
ec3d1006b3
build/release/roms: handle argument properly
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:40:31 +01:00
e0b9766087
build/release/roms: remove superfluous comments
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:36:51 +01:00
681538a20c
build/release/roms: handle errors inside subshell
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:35:36 +01:00
a9bd54423c
build/release/roms: split logic into functions
...
main() on top
top-down logic
79 chars or less, per line
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:33:29 +01:00
2983309006
build/release/roms: use tabs for indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:15:50 +01:00
fff5fa53ff
build/release/src: 79 chars or less per code line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:03:04 +01:00
1cdf1c7cf0
build/release/src: handle errors in subshells
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:59:59 +01:00
16f878e882
build/release/src: split logic into functions
...
main() on top
top-down logic
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:52:33 +01:00
4e2ee58ac5
build/ich9utils: simplify, fix error handling
...
errors weren't being handled inside a subshell
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:32:52 +01:00
93ec91e862
build/memtest86plus: use tabs for indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:28:58 +01:00
4b80f250fb
build/clean/crossgcc: better code style
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:28:17 +01:00
187d5fa418
build/descriptors: simplify and fix error handling
...
main() on top
some parts of the script weren't erroring properly
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:26:09 +01:00
a05be16998
build/grub: fix inconsistent indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:13:44 +01:00
02919c47ce
build/grub: implement error handling
...
it uses a subshell, so errors weren't observed
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:10:41 +01:00
5bab3bbc33
build/grub: introduce main(), split it up
...
easier to read
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:06:15 +01:00
277e1df0af
build/cbutils: remove unnecessary directory check
...
it will already fail if the coreboot download did.
if the coreboot download succeeds, the directory exists.
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:01:02 +01:00
ed9eb4624c
build/cbutils: rename function for clarity
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:00:31 +01:00
b12dced470
build/cbutil: avoid frivilous use of subshells
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 17:57:15 +01:00
355a45b435
build/cbutils: top-down coding style, main on top
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 17:53:03 +01:00
9f58d4e481
build/cbutils: 79 chars or less per line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 16:13:02 +01:00
691f266441
build/cbutils: use tabs for indendation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 16:12:25 +01:00
3cbcfce9d1
gitclone: add my copyright for recent changes
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 13:19:38 +01:00
01a2ab3756
use env in shell scripts
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 13:17:28 +01:00
1e8f2cc170
gitclone: only rm the old directory at the end
...
this way, it will only be deleted after the
new git clone and patching worked successfully
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 13:03:28 +01:00
3da8d20cd6
gitclone: stricter error handling
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 13:01:12 +01:00
e804849486
gitclone: minor cleanup
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 12:56:42 +01:00
fd2ca12e9e
gitclone: split logic out of main()
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 12:55:34 +01:00
08ad9eb15f
download/coreboot: minor cleanup
2023-05-18 12:37:55 +01:00
8d9570b6f7
gitclone: cleaner coding style
...
main() on top
top-down logic
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 12:34:47 +01:00
4ac0bc8d3e
blobutil/download: minor code cleanup
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 11:41:56 +01:00
9fb489ac3e
modify: clean up duplicated code
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 11:24:08 +01:00
f7f3aef17e
modify: cleaner coding style
...
main() on top
top-down logic
reduced indentation
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 11:14:49 +01:00
34df727c98
build: cleaner coding style
...
main() on top
top-down logic
reduced indentation
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 10:49:47 +01:00
1a062bb628
build: reduce code to less than 80 chars per line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 10:21:54 +01:00
a212a5bec8
blobutil: exit 1 if a called script fails
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 10:11:32 +01:00
e62215718c
blobutil: cleaner coding style
...
reduced indentation
main() on top
top-down logic
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 10:09:57 +01:00
c08e3258cb
.gitcheck: exit 1 if unsupported argument given
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 09:55:40 +01:00
c51225577b
.gitcheck: use subshells where appropriate
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 09:49:26 +01:00
dd8fb524df
.gitcheck: re-add redirection to /dev/null
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 09:47:44 +01:00
82c4d7b280
.gitcheck clean: clean coreboot directories too
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 09:44:11 +01:00
0f3c3ca600
.gitcheck: reduce indentation level for loop
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 09:42:06 +01:00
Leah Rowe