ec3d1006b3
build/release/roms: handle argument properly
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:40:31 +01:00
e0b9766087
build/release/roms: remove superfluous comments
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:36:51 +01:00
681538a20c
build/release/roms: handle errors inside subshell
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:35:36 +01:00
a9bd54423c
build/release/roms: split logic into functions
...
main() on top
top-down logic
79 chars or less, per line
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:33:29 +01:00
2983309006
build/release/roms: use tabs for indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:15:50 +01:00
fff5fa53ff
build/release/src: 79 chars or less per code line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 19:03:04 +01:00
1cdf1c7cf0
build/release/src: handle errors in subshells
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:59:59 +01:00
16f878e882
build/release/src: split logic into functions
...
main() on top
top-down logic
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:52:33 +01:00
4e2ee58ac5
build/ich9utils: simplify, fix error handling
...
errors weren't being handled inside a subshell
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:32:52 +01:00
93ec91e862
build/memtest86plus: use tabs for indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:28:58 +01:00
4b80f250fb
build/clean/crossgcc: better code style
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:28:17 +01:00
187d5fa418
build/descriptors: simplify and fix error handling
...
main() on top
some parts of the script weren't erroring properly
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:26:09 +01:00
a05be16998
build/grub: fix inconsistent indentation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:13:44 +01:00
02919c47ce
build/grub: implement error handling
...
it uses a subshell, so errors weren't observed
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:10:41 +01:00
5bab3bbc33
build/grub: introduce main(), split it up
...
easier to read
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:06:15 +01:00
277e1df0af
build/cbutils: remove unnecessary directory check
...
it will already fail if the coreboot download did.
if the coreboot download succeeds, the directory exists.
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:01:02 +01:00
ed9eb4624c
build/cbutils: rename function for clarity
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 18:00:31 +01:00
b12dced470
build/cbutil: avoid frivilous use of subshells
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 17:57:15 +01:00
355a45b435
build/cbutils: top-down coding style, main on top
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 17:53:03 +01:00
9f58d4e481
build/cbutils: 79 chars or less per line
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 16:13:02 +01:00
691f266441
build/cbutils: use tabs for indendation
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-20 16:12:25 +01:00
08ad9eb15f
download/coreboot: minor cleanup
2023-05-18 12:37:55 +01:00
4ac0bc8d3e
blobutil/download: minor code cleanup
...
Signed-off-by: Leah Rowe <leah@libreboot.org>
2023-05-18 11:41:56 +01:00
52d87f5f08
download/coreboot: minor code cleanup
...
i'm pretty much finished now
there might be a few more changes later,
like stricter error handling, more verbose
error messages, etc
right now, it relies on -e to kill lbmk
on error, and uses the exit command
another planned change it to support
other upstreams besides coreboot.org,
such as the dasharo codebase
the latter is *why* i refactored this
download script, for asus kgped-d16
2023-05-15 05:01:48 +01:00
7bd206b9e7
download/coreboot: remove errant code
...
the build_error file is obsolete
2023-05-15 04:53:14 +01:00
bd82d90faf
download/coreboot: tidy up variable names
2023-05-15 04:44:47 +01:00
66d06afd6c
download/coreboot: run extra.sh from cbtree
...
to my knowledge, this feature has never been used,
but lbmk permits resources/coreboot/boardname/extra.sh
to execute, as provided by the maintainer, with working
directory set to: coreboot/boardname
this could be used to extend lbmk in a number of ways
for example, it could be used to patch 3rdparty/
it could also be used to break coreboot in creative
and novel ways. hint hint.
2023-05-15 04:17:50 +01:00
c4b0825c5e
download/coreboot: avoid variable conflict
...
the "board" variable in prepare_new_coreboot_tree()
is also declared in fetch_coreboot_trees
for the one in prepare_new_coreboot_tree, it's passed
as an argument to the function, so give it a new name
i learned that some shells have a global scope, when
using variables of the same name between functions
2023-05-15 04:14:50 +01:00
0e1e9c1773
download/coreboot: fix downloads without argument
...
this should download all trees:
./download coreboot
without this patch, it doesn't
with this patch, it works
i overlooked this during earlier
refactoring. auditing revealed it.
2023-05-15 04:11:10 +01:00
bea6735395
download/coreboot: much cleaner coding style
...
top-down order, and *still* rfc 3676 compliant
i finished simplifying the logic, and
i split everything into smaller functions
there is still more more polishing to do
final touches will be done in new revisions
2023-05-15 04:05:27 +01:00
2d69072a09
download/coreboot: clone upstream via ./gitclone
...
coreboot trees/patching is still handled
specifically by "./download coreboot"
command now available in lbmk:
./gitclone coreboot
this *only* creates the directory at:
coreboot/coreboot
this directory is never used in builds.
it is only used by download/coreboot to
create patched trees for each mainboard
2023-05-15 03:24:19 +01:00
c17423e475
download/coreboot: simplify check
2023-05-15 02:51:15 +01:00
00cafd7022
download/coreboot: fix misnamed function
2023-05-15 02:39:29 +01:00
86512e84be
download/coreboot: simplify small if statements
2023-05-15 02:38:22 +01:00
d28584f3d0
download/coreboot: fetch config in new function
2023-05-15 02:30:14 +01:00
162f4bf5dd
download/coreboot: use global variables
...
i'm going to move the config recursion check
into a separate function, and global variables
make it easier to handle
2023-05-15 02:17:39 +01:00
56b80c0a4c
download/coreboot: rename function for clarity
2023-05-15 01:25:08 +01:00
ee79d8ba95
download/coreboot: reduce indentation in loop
2023-05-15 01:21:20 +01:00
f858baea93
download/coreboot allow downloading specific trees
...
this fixes a regression caused in previous (recent)
revisions. this script is a beast, and requires a
lot of taming, which is the purpose of my audit
2023-05-15 01:12:37 +01:00
a33e5c67f3
download/coreboot: split config check to function
2023-05-15 01:07:32 +01:00
62038f1d03
download/coreboot: fix misnamed variable
2023-05-15 00:47:31 +01:00
342e846f28
download/coreboot: consistent function declaration
2023-05-15 00:44:26 +01:00
c32ae5979f
download/coreboot: rename function for clarity
2023-05-15 00:43:55 +01:00
e47aaa8ff0
download/coreboot: prune errant comments
2023-05-15 00:42:36 +01:00
31d8fcd3fd
download/coreboot: split main()
2023-05-15 00:40:54 +01:00
4c2cff5e7c
download/coreboot functions: rename board variable
2023-05-15 00:27:08 +01:00
7a6f40fcbf
download/coreboot: top-down re-ordering
...
main first
usage last
2023-05-15 00:22:54 +01:00
fd8b8084ee
download/coreboot: simplified for loops
2023-05-15 00:21:16 +01:00
b24fbc74c3
download/coreboot: move initial logic to main()
2023-05-15 00:10:37 +01:00
2871db159d
download/coreboot: RFC 2646 compliance
...
yes, i know 3676 supersedes 2646
i still say 2646
saying 2646 is still technically valid,
for my purposes
2023-05-15 00:03:56 +01:00
Leah Rowe