treehouse
/
mastodon
19
8
Fork 5
Code Issues 32 Pull Requests Projects 1 Releases Wiki Activity

fix missing link style in admin.scss - actually this time #29

Merged
kouhai merged 4 commits from link-fix into main 2022-12-09 06:28:14 +00:00
Conversation 2 Commits 4 Files Changed 2
Rin commented 2022-12-08 05:35:02 +00:00
Owner

Re: #20

That did not actually fix the issue in all views, whereas this should. Will test further before requesting merge.

Currently being worked on upstream as https://github.com/glitch-soc/mastodon/pull/1999

Re: #20 That did not actually fix the issue in all views, whereas this should. Will test further before requesting merge. Currently being worked on upstream as https://github.com/glitch-soc/mastodon/pull/1999
kouhai was assigned by Rin 2022-12-08 05:35:02 +00:00
Rin added 1 commit 2022-12-08 05:35:03 +00:00
ci/woodpecker/push/woodpecker Pipeline was successful Details
ci/woodpecker/pr/woodpecker Pipeline was successful Details
7bf26a1094
fix missing link style in admin.scss - actually this time
Rin added 3 commits 2022-12-08 07:31:13 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
ci/woodpecker/push/woodpecker Pipeline was successful Details
aa24b2d072
make glitch style consistent
Rin changed title from WIP: fix missing link style in admin.scss - actually this time to fix missing link style in admin.scss - actually this time 2022-12-08 07:42:33 +00:00
Rin requested review from kouhai 2022-12-08 07:42:48 +00:00
fox commented 2022-12-09 03:42:47 +00:00
Owner

LGTM

I wasn't sure where .strike-card is used, but the changes look very reasonable and glitch is advocating an upstream PR.

LGTM I wasn't sure where `.strike-card` is used, but the changes look very reasonable and glitch is advocating an upstream PR.
kouhai merged commit aa24b2d072 into main 2022-12-09 06:28:14 +00:00
kouhai deleted branch link-fix 2022-12-09 06:28:14 +00:00
kouhai commented 2022-12-09 06:28:39 +00:00
Owner

oops, meant to rebase then squash, oh well

oops, meant to rebase then squash, oh well
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
kouhai
Labels
Clear labels
  
area/i18n

Internationalization   
area/infrastructure

Infrastructure and operations   
area/moderation & safety
   
area/ux

User experience   
priority/1.high
   
priority/2.medium
   
priority/3.low
   
tag/upstream issue

This issue should be filed against upstream   
tag/duplicate

This issue or pull request already exists   
tag/help wanted

Feedback and pull requests welcome!   
tag/invalid

Something is wrong   
tag/won't fix

This won't be fixed   
type/bug

Something is not working   
type/enhancement

New feature   
type/question

More information is needed
No Label
area/i18n
area/infrastructure
area/moderation & safety
area/ux
priority/1.high
priority/2.medium
priority/3.low
tag/upstream issue
tag/duplicate
tag/help wanted
tag/invalid
tag/won't fix
type/bug
type/enhancement
type/question
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
kouhai
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: treehouse/mastodon#29
There is no content yet.
Delete Branch "link-fix"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?