Add prefers-color-scheme based theme #6

hamptonmoore · 2022-11-09T19:36:31Z

hamptonmoore commented

2022-11-09 19:36:31 +00:00

This adds a skin that prefers dark mode, but becomes light if the users browser prefers-color-scheme is set to light. It also fixes the naming for vanilla mastondon light in spanish as the names.yml accidentally had glitch in it.

hamptonmoore added 1 commit 2022-11-09 19:36:32 +00:00

652882a81b Add prefers-color-scheme based theme

kouhai commented

2022-11-09 20:06:16 +00:00

Nits (non-blocking):

Personally would've preferred two commits
Not sure about name. What about Mastodon (system default)?

Questions (blocking):

How have you tested this? Still getting up to speed on the mastodon codebase, so I'm not the most familiar with P(breakage).
Can you submit this to upstream glitch? After doing so, please add the following to your commits:
```
Upstream: <pr-link>
```
We don't have a good strategy yet, so I'm erring on "track more information".
What does this do to CSS bundle size?

Nits (non-blocking): - Personally would've preferred two commits - Not sure about name. What about `Mastodon (system default)`? Questions (blocking): - How have you tested this? Still getting up to speed on the mastodon codebase, so I'm not the most familiar with P(breakage). - Can you submit this to upstream glitch? After doing so, please add the following to your commits: ``` Upstream: <pr-link> ``` We don't have a good strategy yet, so I'm erring on "track more information". - What does this do to CSS bundle size?

kouhai requested review from kouhai 2022-11-09 20:06:25 +00:00

kouhai requested changes 2022-11-09 20:07:49 +00:00

kouhai left a comment

Once the above questions are addressed one way or another, I'll approve+merge.